Avoid DeprecationWarning about ABC in Python 3.x#1354
Merged
sloria merged 1 commit intomarshmallow-code:2.x-linefrom Aug 20, 2019
Merged
Avoid DeprecationWarning about ABC in Python 3.x#1354sloria merged 1 commit intomarshmallow-code:2.x-linefrom
sloria merged 1 commit intomarshmallow-code:2.x-linefrom
Conversation
Python 3.x complains about the `collections.Mapping` vs `collections.abc.Mapping`. There is already a shim for it in `marshmallow.compat`, so switched to using that.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.x complains about the
collections.Mappingvscollections.abc.Mapping. There is already a shim for it inmarshmallow.compat, so switched to using that.Though I poked at the
collections.Mappingin 3.8 and it said "...is deprecated since Python 3.3,and in 3.9 it will stop working", so it's maybe not as critical, but it removes nagging. See python/cpython#13409